Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -e to keep synergy with every other script #405

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Use -e to keep synergy with every other script #405

merged 1 commit into from
Sep 18, 2024
+2 −2

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 16, 2024 •
edited
Loading

Type of Change

  • New feature
  • Refactoring
  • Hotfix
  • Security patch

Description

No explanation needed. Ref - PR Title

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx nnyyxxxx mentioned this pull request Sep 16, 2024
Closed
@nnyyxxxx nnyyxxxx changed the title Use -e & Keep synergy with every other script Use -e to keep synergy with every other script Sep 16, 2024
@jeevithakannan2 jeevithakannan2 mentioned this pull request Sep 16, 2024
Open
5 tasks
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Sep 16, 2024 •
edited
Loading

Duplicate of #388

Not a duplicate, that was committed after this PR, I suggested changes as well. @jeevithakannan2 You should keep your pull requests focused. cfd6cca

@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Sep 16, 2024 •
edited
Loading

No need of two separate PRs for a simple change

@nnyyxxxx nnyyxxxx closed this Sep 16, 2024
@jeevithakannan2
Copy link
Contributor

Reverted as per your wish

@jeevithakannan2
Copy link
Contributor

@nnyyxxxx You are wasting time and it's a simple fix, it doesn't need two separate PRs. I am not stealing your commits and I will not. I don't know why you make small things a big issue and accuse people. I am not going to argue with you over this small issue not worth my time

@nnyyxxxx nnyyxxxx reopened this Sep 16, 2024
@nnyyxxxx
Copy link
Contributor Author

Re-opened due to revert.

@nnyyxxxx
Copy link
Contributor Author

@nnyyxxxx You are wasting time and it's a simple fix, it doesn't need two separate PRs. I am not stealing your commits and I will not. I don't know why you make small things a big issue and accuse people. I am not going to argue with you over this small issue not worth my time

Never said you were, I'm only saying that this is not a duplicate, that commit that I linked was made an hour after this PR was opened with the fix.

@ChrisTitusTech ChrisTitusTech merged commit 857ad80 into ChrisTitusTech:main Sep 18, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the testing-16 branch September 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use -e to keep synergy with other scripts
4 participants
@nnyyxxxx @jeevithakannan2 @ChrisTitusTech @adamperkowski