-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list #387
fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Please remove these lines from the code https://github.com/ChrisTitusTech/linutil/blob/main/tui%2Fsrc%2Ffloating_text.rs#L105-L108 Your implementation is better and these lines are not necessary if this is merged |
@ChrisTitusTech please implement the above requested changes before merging |
Thanks to @jeevithakannan2 for idea
Fixup rendering of floating text and logc of preview key binding being shown in shortcut list
Type of Change
Description
Any floating content that gets rendered has the possibility of rendering any text from the underlying widget. Prior to drawing the float content, the area that the float content is rendered to should be cleared prior to drawing the float content.
Impact
Having extraneous text present within the preview area might confuse users if the text that is presented from the underlying widget looks like valid bash. This removes the possibility for confusion.
Also, the key binding for showing the preview isn't rendered if the list widget is at the top-level dir of a category, but is properly shown in subdirs. The previewing capability is pretty nifty and should be properly displayed as a key binding when valid.
Issue related to PR
Checklist