[WIP] @semanticNonNull support #7681
Draft
+1,020
−1,819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
79ec25d
to
1f766a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7681 +/- ##
==========================================
- Coverage 73.94% 73.92% -0.02%
==========================================
Files 2916 2918 +2
Lines 151060 151170 +110
Branches 17548 17568 +20
==========================================
+ Hits 111696 111754 +58
- Misses 33511 33562 +51
- Partials 5853 5854 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
glen-84
reviewed
Nov 5, 2024
| /// <summary> | ||
| /// Gets or sets the name of the query type. | ||
| /// </summary> | ||
| /// <inheritdoc cref="IReadOnlySchemaOptions.QueryTypeName"/> |
There was a problem hiding this comment.
I don't think that these crefs are needed.
glen-84
reviewed
Nov 5, 2024
|
|
||
| public class Query | ||
| { | ||
| [GraphQLNonNullType()] |
There was a problem hiding this comment.
Suggested change
| [GraphQLNonNullType()] | |
| [GraphQLNonNullType] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.