Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opt-in features #7652

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added opt-in features #7652

wants to merge 5 commits into from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Oct 28, 2024

Summary of the changes (Less than 80 chars)

  • Added opt-in features.

❓ Questions:

  • Please check the schema error definitions in ErrorHelper.cs.
    • Should I be setting an error code or specified by?
  • I'm returning one error for each application of the directive, is that correct?
    • In theory, we could be including information about the directive syntax position, arguments, etc.

📓 Spec notes:

  • Should we explicitly disallow empty and whitespace-only feature strings? *
  • Should we disallow whitespace or other characters within feature names, or leave it completely open? *
  • I've used includeOptIn instead of includeRequiresOptIn for introspection, as it seemed more clear, WDYT?

* stability strings as well.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (28e169d) to head (8e5e2d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7652      +/-   ##
==========================================
+ Coverage   73.82%   73.91%   +0.08%     
==========================================
  Files        2918     2929      +11     
  Lines      151114   151541     +427     
  Branches    17555    17602      +47     
==========================================
+ Hits       111565   112006     +441     
+ Misses      33726    33706      -20     
- Partials     5823     5829       +6     
Flag Coverage Δ
unittests 73.91% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review October 30, 2024 09:13
@michaelstaib michaelstaib added this to the HC-14.2.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants