Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos in dataloader docs / improve grammatical consistency #7645

Merged
merged 11 commits into from
Oct 29, 2024
Merged

Fixed typos in dataloader docs / improve grammatical consistency #7645

merged 11 commits into from
Oct 29, 2024

Conversation

lemonez
Copy link
Contributor

@lemonez lemonez commented Oct 24, 2024

Summary of the changes (Less than 80 chars)

  • documentation-only change that fixes typos / makes capitalization and wording consistent for data loaders

Closes #bugnumber (in this specific format)

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Oct 24, 2024
michaelstaib
michaelstaib requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataLoader is a fixed term:
https://github.com/graphql/DataLoader

lemonez and others added 9 commits October 24, 2024 14:03
@lemonez @michaelstaib
Update website/src/docs/hotchocolate/v11/fetching-data/dataloader.md
4f733dd 
implement suggested comment for capitalization

Co-authored-by: Michael Staib <[email protected]>
@lemonez @michaelstaib
Update website/src/docs/hotchocolate/v12/fetching-data/dataloader.md
15d1929 
implement suggested comment for capitalization

Co-authored-by: Michael Staib <[email protected]>
@lemonez
Merge branch 'main' into ehc/dataloader-docs-typos
51493d1
@lemonez @michaelstaib
Update website/src/docs/hotchocolate/v11/fetching-data/dataloader.md
3c1c610 
implement suggested comment for capitalization

Co-authored-by: Michael Staib <[email protected]>
@lemonez
Update dataloader.md
03644c9 
fix capitalization
@lemonez
Update dataloader.md
feeeb5b 
fix capitalization
@lemonez
Update dataloader.md
d3d7e8e
@lemonez
Update dataloader.md
4bfe62a 
fix capitalization
@lemonez
Update dataloader.md
f157520 
fix capitalization
@glen-84 glen-84 changed the title fix typos in dataloader docs / improve grammatical consistency Fix typos in dataloader docs / improve grammatical consistency Oct 25, 2024
bbrandt
bbrandt suggested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@bbrandt bbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be up to the team to decide if this change is useful or not, but I noted a few places pluralization should be used.

website/src/docs/hotchocolate/v14/fetching-data/dataloader.md Show resolved Hide resolved
website/src/docs/hotchocolate/v14/fetching-data/dataloader.md Show resolved Hide resolved
@michaelstaib michaelstaib changed the title Fix typos in dataloader docs / improve grammatical consistency Fixed typos in dataloader docs / improve grammatical consistency Oct 29, 2024
@michaelstaib michaelstaib merged commit 497b717 into ChilliCream:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glen-84 glen-84 glen-84 approved these changes

@bbrandt bbrandt bbrandt requested changes

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
📚 documentation This issue is about working on our documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lemonez @CLAassistant @glen-84 @bbrandt @michaelstaib