Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FieldSelectionMap parser #7211

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 1, 2024

Summary of the changes (Less than 80 chars)

  • Added FieldSelectionMap parser.

Notes:

  1. I'm not sure if the FieldSelectionMapSyntaxSerializer is correct, taking over the visitation and then returning Skip.
  2. Since the parser is similar to the main GraphQL parser, it is affected by the same issue with locations (incorrect End values).
  3. The following types could potentially be shared.
    • Location (if the ISyntaxNode crefs were removed)
    • TokenInfo (if the ISyntaxNode crefs were removed)
    • ISyntaxVisitorAction
    • SyntaxVisitorActionKind
    • SyntaxVisitorActionExtensions
    • *SyntaxVisitorAction

@glen-84 glen-84 marked this pull request as draft July 1, 2024 11:09
@michaelstaib michaelstaib changed the base branch from fusion-vnext to main October 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants