feat: attach Diagnostic to 'wrong number of arguments' error

Chen-Yuan-Lai · Feb 13, 2025 · ade724e · ade724e
1 parent 3e6d70e
commit ade724e
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/datafusion/expr/src/type_coercion/functions.rs b/datafusion/expr/src/type_coercion/functions.rs
@@ -26,7 +26,7 @@ use datafusion_common::{
     exec_err, internal_datafusion_err, internal_err, not_impl_err, plan_err,
     types::{LogicalType, NativeType},
     utils::list_ndims,
-    Result,
+    Diagnostic, Result, Span,
 };
 use datafusion_expr_common::{
     signature::{
@@ -469,7 +469,15 @@ fn get_valid_types(
         if length != expected_length {
             return plan_err!(
                 "Function '{function_name}' expects {expected_length} arguments but received {length}"
-            );
+            ).map_err(|err| {
+                err.with_diagnostic(
+                    Diagnostic::new_error(
+                        format!("Function '{function_name}' expects {expected_length} arguments but received {length}"),
+                        Span::new(0, 0),
+
+                    )
+                )
+            });
         }
         Ok(())
     }