chore: disable Qt5 builds in CI #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
reviewed
Feb 8, 2025
| @@ -143,7 +142,7 @@ jobs: | |||
| include: | |||
| # macOS | |||
| - os: macos-13 | |||
There was a problem hiding this comment.
Could we bump this to macos-latest too? iirc, the reason we were using macos-13 was because Qt5 didn't work on ARM macs.
There was a problem hiding this comment.
I think the reason for macos-13 was some C++20 code not working in #4970 (See third bullet point of description)
I don't remember which one, tho.
There was a problem hiding this comment.
That was because macos-latest resolved to macos-12 at the time. So we should be fine with using latest.
There was a problem hiding this comment.
Will do this in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this is not to remove every single ifdef qt version thing we have, but instead to stop building for Qt5 in CI.
New code we write should not have to pass Qt5 CI to be accepted in the codebase.