Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(notifications): remove platform specifier #5914

Merged

Conversation

apa420
Copy link
Collaborator

@apa420 apa420 commented Feb 7, 2025

Remove unused platform specifier that isn't used. We can only create toasts for a TwitchChannel so this is not necessary.

if (showNotification &&
this->isChannelNotified(payload.channelName, Platform::Twitch))

@pajlada
Copy link
Member

pajlada commented Feb 7, 2025

Waiting until after #5881 to merge this in

@pajlada
Copy link
Member

pajlada commented Feb 8, 2025

I can review this now when the merge conflicts have been fixed

@pajlada pajlada changed the title Chore: Remove unused platform specifier in toasts refactor(notifications): remove platform specifier Feb 9, 2025
@pajlada pajlada enabled auto-merge (squash) February 9, 2025 11:25
@pajlada pajlada merged commit 7dad35b into Chatterino:master Feb 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants