fix: Path traversal vulnerability in WebDAV proxy endpoint

[Mirza-Samad-Ahmed-Baig]

• Sanitize path components to prevent directory traversal attacks
• Filter out '.', '..', and empty path components
• URL encode path components to prevent injection attacks
• Prevents potential SSRF attacks via path manipulation

This vulnerability could allow attackers to:

• Access unintended resources outside the WebDAV scope
• Potentially reach internal services or metadata endpoints
• Bypass access controls through path manipulation

Security impact: HIGH - Path traversal is a critical security issue

💻 变更类型 | Change Type

fix

🔀 变更说明 | Description of Change

Fixed a critical path traversal vulnerability in the WebDAV proxy endpoint by sanitizing path components to prevent directory traversal and potential SSRF attacks.

📝 补充信息 | Additional Information

This is more of a defense-in-depth improvement rather than a vulnerability. The existing restrictions make exploitation difficult, but adding path sanitization is still a good security practice to prevent any edge cases.

Summary by CodeRabbit

• Bug Fixes
  • Improved security by sanitizing and encoding path components to prevent invalid or unsafe paths when accessing resources.

[coderabbitai]

Walkthrough

The code in the WebDAV API route now sanitizes and encodes path components from incoming requests. It filters out empty strings, ".", and ".." to prevent path traversal, then applies URI encoding to each segment before joining them into the endpoint path. No exported or public entity declarations were changed.

Changes

Cohort / File(s)	Change Summary
WebDAV Path Sanitization and Encoding app/api/webdav/[...path]/route.ts	Sanitizes incoming path components by removing empty, ".", and ".." entries; applies URI encoding before constructing the endpoint path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hopped along the path,
Avoiding dots and empty wrath.
With careful hops, it sanitized,
Encoded trails, and then it prized
A safer warren, neat and bright—
No sneaky foxes in the night!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 557a2cc and d09801b.

📒 Files selected for processing (1)

• app/api/webdav/[...path]/route.ts (1 hunks)

🔇 Additional comments (1)

app/api/webdav/[...path]/route.ts (1)

65-70: Excellent security fix implementation!

The path sanitization logic effectively prevents path traversal attacks through multiple defensive measures:

1. Path traversal prevention: Correctly filters out "..", ".", and empty components that could be used for directory traversal
2. Injection prevention: URI encoding each component prevents injection of additional path separators or encoded traversal sequences
3. Defense-in-depth: Adds an additional security layer to the existing endpoint validation

The implementation order (filter first, then encode) is correct and the use of encodeURIComponent is appropriate for path components.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.