Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech stack: Go: add Errors section #62

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Aug 11, 2022

➡️ Rendered

Progress:

  • Errors introduction
  • Whether to export sentinel errors
  • Wrap or wrapped
  • Whether to add context
  • Concrete example
  • Testing errors
  • Debated with the Gossamer team (others are welcome too)
  • Improve concrete example code

@render
Copy link

render bot commented Aug 11, 2022

@qdm12 qdm12 force-pushed the qdm12/tech-stack/go/errors branch from fa6ea98 to 673749c Compare August 11, 2022 15:21
@qdm12 qdm12 changed the title Tech stack: Go: add Mocking section Tech stack: Go: add Errors section Aug 11, 2022
@qdm12 qdm12 force-pushed the qdm12/tech-stack/go/errors branch from 97fb185 to 78712ba Compare August 11, 2022 16:42
@qdm12 qdm12 marked this pull request as ready for review September 16, 2022 20:40
@mpetrunic
Copy link
Member

conflicts^^

@qdm12 qdm12 force-pushed the qdm12/tech-stack/go/errors branch from e791f30 to fc15406 Compare November 9, 2022 10:06
@qdm12
Copy link
Contributor Author

qdm12 commented Dec 2, 2022

Please hold on merging this, I need to add the sentinel error definition 😉

@qdm12
Copy link
Contributor Author

qdm12 commented Dec 5, 2022

Please hold on merging this, I'll review example code and improve it soon-ish.

@ChainSafe ChainSafe deleted a comment from CLAassistant Feb 13, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mpetrunic mpetrunic marked this pull request as draft January 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants