Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: monorepo.md corepack issue note #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Typescript: monorepo.md corepack issue note #100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e033b
Update monorepo.md
BeroBurny Nov 22, 2023
70b75b9
Update docs/3_development/2_tech-stack/Typescript/monorepo.md
BeroBurny Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/3_development/2_tech-stack/Typescript/monorepo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ If you are running node@16+, you just need to run `corepack enable`.
If you are running older version, run `npm i -g corepack`.
Make sure you put this in README file for future contributors.

:::warning

Date: 22 November 2023
There is an issue with `actions/setup-node@v3` it is used with `cache: 'yarn'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is an issue with `actions/setup-node@v3` it is used with `cache: 'yarn'`
There is an issue with `actions/setup-node@v3` if is used with `cache: 'yarn'`

can you link issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no exact issue, but here is some info
actions/setup-node#480 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, maybe better to add instructions to install cache in separate step (after corepack enable)


:::

### 2. Init repository

- Make sure your root `package.json` contains:
Expand Down