Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain crate init #9

Merged
merged 26 commits into from
Nov 13, 2023
Merged

Offchain crate init #9

merged 26 commits into from
Nov 13, 2023

Conversation

ross-weir
Copy link
Member

@ross-weir ross-weir commented Nov 8, 2023

  • Handle all Results instead of using unwrap
  • Extract reserve tx creation in a way that it decouples from node usage in order to make it testable.
  • Check tx json output against scala chaincash output if it's still up to date
  • Add API method /reserves/mint
  • Real test on testnet, create a reserve box can't be done without more work: ergo-node-interface can't be used in async contexts #13

@ross-weir ross-weir added this to the MVP milestone Nov 9, 2023
@ross-weir ross-weir marked this pull request as ready for review November 12, 2023 09:25
@ross-weir ross-weir requested a review from kushti November 12, 2023 09:28
@ross-weir ross-weir merged commit bf3d1eb into master Nov 13, 2023
1 check passed
@ross-weir ross-weir deleted the offchain-crate-init branch November 13, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant