-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add support for GLTF extension: EXT_mesh_primitive_edge_visibility #12859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielzhong
wants to merge
60
commits into
main
Choose a base branch
from
edge_line_unique_VAO
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/danielzhong/cesium into danielzhong/edge_line_unique_VAO
Thank you for the pull request, @danielzhong! ✅ We can confirm we have a CLA on file for you. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the proposed GLTF extension
EXT_mesh_primitive_edge_visibility
, enabling edge rendering for glTF mesh primitives. It adds multi-pass rendering to avoid z-fighting, and implements decoding, creation, and rendering of both hard and silhouette edges:More details: Edge Visibility
Example

(green edge = hard edge; red edge = silhouette edge):
Issue number and link
#12765
Testing plan
Added Unit test for Edge Frame Buffer, MRT & Shader Color Attachments, Decoding logic, Shader Generation, etc.
Real Time Demo
Local Test File:
super_simple_3.bim-tiles.zip
How to Run:
http-server ./ --cors=X-Correlation-Id
Make sure change your local host address in the code!
((green edge = hard edge; red edge = silhouette edge):)

🔍Review Notes
getWebGLStub.js
to support MRT in coverage tests.Bug Fix Summary
modelFS.glsl
. The model runtime primitive couldn’t detect the render tag (it runs too early), so I introduced a uniform flag to detect when the pipeline stage is active.clearCommand
inEdgeFramebuffer.js
.getWebGLStub.js
to support MRT in coverage tests.Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change