Skip to content

Conversation

lukemckinstry
Copy link
Contributor

@lukemckinstry lukemckinstry commented Aug 13, 2025

Description

Builds off #12588, adds support for Scene2D and Columbus View

ToDo:

  • local transforms (ie. wrong orientation for instances at correct location) for earth centered model
  • Columbius View model scaling issue
  • Precompute values / performance
  • Improve clarity on "2D" variable and functions in code comments
  • glTF with top level components transform (earth centered) components.transform is just used for i3dm tilesets
  • tests for ModelDrawCommands createCommandModelMatrix and createCommandBoundingSphere
  • check effects when switching sceneMode when zoomed all the way out in 2D mode, it looks like instances close together are impacted by z-fighting
  • Unify code paths for earth-centered and non-earth-centered models
    • combine 3D modelMatrix & instance transform, calculate 2D transform, then remove modelMatrix
  • This feature is good to add to release regression tests (3D, 2D, CV) because it is clear to test and tell when something is broken
Screenshot from 2025-08-13 16-28-53

Issue number and link

#10846

Testing plan

  • Instanced model centered on earth origin - link
  • Instanced model centered at arbitrary location - link
    • Earth surface with small transforms
    • larger transforms
  • Columbus view

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @lukemckinstry!

✅ We can confirm we have a CLA on file for you.

@lukemckinstry

This comment was marked as resolved.

@lukemckinstry lukemckinstry force-pushed the model-instance-2Dfixes branch from 2dccd46 to 5a749a2 Compare August 19, 2025 20:24
@lukemckinstry lukemckinstry marked this pull request as ready for review August 19, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant