-
Notifications
You must be signed in to change notification settings - Fork 3.7k
ModelInstanceCollection 2D Scene support #12816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukemckinstry
wants to merge
15
commits into
model-instance-v2
Choose a base branch
from
model-instance-2Dfixes
base: model-instance-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the pull request, @lukemckinstry! ✅ We can confirm we have a CLA on file for you. |
eab030f
to
99bb138
Compare
dfd4f43
to
b7b5106
Compare
This comment was marked as resolved.
This comment was marked as resolved.
19 tasks
b253ede
to
abe09cb
Compare
ac6c8fc
to
e611a7b
Compare
2dccd46
to
5a749a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds off #12588, adds support for Scene2D and Columbus View
ToDo:
glTF with top level components transform (earth centered)components.transform is just used for i3dm tilesetscheck effects when switching sceneModewhen zoomed all the way out in 2D mode, it looks like instances close together are impacted by z-fightingIssue number and link
#10846
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change