Defer DestroyTileset to the next Tick when RefreshTileset is called
#1785
+23
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implementation is inspired by what we do in Cesium for Unity. Instead of calling
DestroyTilesetimmediately inRefreshTileset, this queues the function to happen on the nextTick(). This does not affect object destruction when the Actor itself is destroyed.Issue number or link
Fixes #1784.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.[ ] I have updated the documentation as necessary.Testing plan
Go through the Reproduction Steps in #1784 and confirm they don't result in a crash.