camera: simulated: fix continuous streaming mode, exposure, other #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the simulated camera such that it replicates the behavior of the other cameras: you need to send a trigger to get frames, unless in continuous streaming mode.
It also fixes the continuous streaming mode for the sim cam which was broken before, and caused printouts even when not in continuous streaming mode.
NOTE: There's still an issue whereby we do not turn off streaming after acquisitions, or properly turn off streaming after live mode. So sometimes if you're in continuous mode, you'll see that frames are still streamed (because we don't turn off streaming). This is a separate issue that we need to fix.
Tested By: Unit tests pass, also when in simulated gui mode no printouts from the streaming thread occur unless in continuous triggering mode.