update LaserAutofocusSettingWidget

[Alpaca233]

• show spot detection plot
• show error message on spot detection failure
• save threshold properties without initialization

[ianohara]

Do we need to do any data validation on these? Or is it safe to trust that the spinboxes will do the validation for us?

[Alpaca233]

I think the spinboxes will do the validation.

[hongquanli]

What if user enter 0 or negative value?

[ianohara]

Using the bare string here is fragile - if someone changes the name of the tab, then this breaks. A safer and easier to maintain way to do this is to pull the tab name out into a class variable. For instance (details missing - but this'll give you an idea):

class HighContentScreeningGui(QMainWindow):
    LASER_BASED_FOCUS_TAB_NAME = "Laser-Based Focus"

    def setupImageDisplayTabs(self):
                    self.imageDisplayTabs.addTab(laserfocus_dockArea, HighContentScreeningGui.LASER_BASED_FOCUS_TAB_NAME)


    def toggleNapariTabs(self):
        # ...
        if self.imageDisplayTabs.tabText(i) != HighContentScreeningGui.LASER_BASED_FOCUS_TAB_NAME:
           # ...

Alternatively, and even better, we wouldn't use the tab name (since that is really just for human interaction, and can change too easily. For instance - if someone adds a feature that changes the tab name based on context, this will still break).

[Alpaca233]

Is there a good identifier for the tabs? I think index may also change.