Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4255] update to public true on ham just the objects that were public before were spammed #10970

Open
wants to merge 2 commits into
base: feature/b-and-i-25-01
Choose a base branch
from

Conversation

mkovalua
Copy link

@mkovalua mkovalua commented Feb 11, 2025

Purpose

When a user is is designated as Spam, and then confirmed as Ham, sometimes their preprints remain set to private.
It is needed to update to public true on ham just the objects that were public before were spammed.

Changes

It is needed to was_public parameter from the latest spammed log that was after public/private changings

preprint

Screen.Recording.2025-02-11.at.16.22.56.1.mp4

registration

Screen.Recording.2025-02-11.at.20.23.09.mp4

node (branched embargoed registration from project)

Screen.Recording.2025-02-13.at.00.05.32.1.mov

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-4255

@brianjgeiger brianjgeiger changed the title ENG-4255 update to public true on ham just the objects that were public before were spammed [ENG-4255] update to public true on ham just the objects that were public before were spammed Feb 13, 2025
Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests please, both to catch the new functionality and, if they don't exist, to make sure you don't accidentally make something public that shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants