-
-
Notifications
You must be signed in to change notification settings - Fork 227
Add Obtainum Link and Pic #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hidrohase
wants to merge
1
commit into
CatimaLoyalty:main
Choose a base branch
from
hidrohase:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I really want to promote Obtainium. I know it's popular, but I think the attitude of grabbing APKs from dev's GitHub releases directly with 0 security scanning is generally a bad way to get software (though it may still be better than Google Play as Google is extremely abusive to developers).
My main issue is that this URL is basically impossible for me to review, it's extremely long and I have no clue how to tell if it's correct. I also don't know where that GitHub src is coming from.
I also don't understand why the button is needed? If Obtainium does GitHub, why doesn't it just work instantly on the GitHub URL itself?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obtainium does not grap any APKs from deves. It purely links to the repro.
The link is basicly a convinience. You can add the git just as is to Obtainium and do the two adjustments I included: 1. It says to scan for the "latest" tag. 2. It Sets the name of the App inside of Obtainium to "Catima" as the standard-setting just grabs the name of the repro "Android".
You can verify the validity of the Link if you have Obtainium installed (which of course is an ask). The link itself does not actually go to Obtainium, it just uses the callup of the obtainium app which then reads all information from the link itself.
Or you can look at the link it is basicly a json put into a link which gives obtainium the above meintioned instructions.
About security: Well it is as secure as your git is, as it does nothing more then load it from here and check the provided sha against the apk.
For some apps, if the providers don't have a git or have some strange constructions or namings in their repro one can refine the selection with regex and some other options.
Also Obtainium is GPL-3.0 license so you can look at what it does.
tl:dr
No APKs are grabbed, link is for convenience for Obtainium-users, URL is just json instructions for the App
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and about where the scr is from, its directly from the Obtainium repo: https://github.com/ImranR98/Obtainium/blob/main/assets/graphics/badge_obtainium.png