Allow fallback to front or back image for thumbnail if icon image is not set#1930
Closed
TheLastProject wants to merge 3 commits intomainfrom
Closed
Allow fallback to front or back image for thumbnail if icon image is not set#1930TheLastProject wants to merge 3 commits intomainfrom
TheLastProject wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
The slowdown seems to be caused by This is generally just bad code, it should try to load the image async. It's not really directly linked to this, but if we're going to silently start loading more stuff we should consider being a bit more careful. |
Simplifies the logic for the icon -> front -> back fallback
This ensures scrolling stays smooth on slow devices
TheLastProject
force-pushed
the
feature/fallbackIconToFrontOrBack
branch
from
31836a2 to
eeda041
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1929
To decide: how should this interact with #1889?