Add warning notification and add utility function to passes #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denismerigoux
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks! I let @AltGr give his opinion about the refactor of driver.ml
vincent-botbol
force-pushed
the
vbot@warnings_notification
branch
from
c7c3b3c
to
15b101a
Compare
vincent-botbol
force-pushed
the
vbot@warnings_notification
branch
from
15b101a
to
5f57f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plugs warnings notification mechanism that's currently used for errors messages.
It also refactors the driver's passes so that it offers more control which is needed in LSP.We also add a global option to handle include resolving introduced by #688Edit: I don't need this rework as of right now and I'm still not sure that it's sufficient for what I want to achieve so I removed it from the PR.