Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry over binders positions in EAbs #734

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

vincent-botbol
Copy link
Contributor

This PR augments the EAbs's node with the position of binded variables. This allows the LSP server to handle such variables and references them for the user which was not previously possible.

@vincent-botbol vincent-botbol changed the title Carry positions of binders in EAbs Carry over binders positions in EAbs Oct 28, 2024
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks very nice! I'm curious to discuss tomorrow how you found a solution that only adds positions to the binders and not the bound variables lower in the AST.

Copy link
Contributor

@AltGr AltGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@vincent-botbol vincent-botbol merged commit 1944b86 into master Oct 30, 2024
5 checks passed
@vincent-botbol vincent-botbol deleted the vbot@add_pos_to_abs branch October 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants