C backend: workaround bulk freeing of constants #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Constants may need initialisation and allocations, which we do lazily, but that doesn't combine well with the way our allocator works, freeing everything in bulk. This patch adds a switch to the allocator that make it use raw `malloc`, which is turned on within the initialisation functions of constants. A cleaner solution will be to let Catala proceed normally but do a copy to persistent memory afterwards; we'll need to implement this copy anyway for consumers to more easily recover results from calls to catala.
|
Once we have functions to promote values allocated within the catala heap to persistent memory, these should be leveraged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constants may need initialisation and allocations, which we do lazily, but that
doesn't combine well with the way our allocator works, freeing everything in
bulk.
This patch adds a switch to the allocator that make it use raw
malloc, whichis turned on within the initialisation functions of constants.