Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building for more systems #665

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

faezs
Copy link
Contributor

@faezs faezs commented Aug 5, 2024

Don't know if this matches the CI philosophy but happy to make changes if extra systems need to be disabled there

@faezs
Copy link
Contributor Author

faezs commented Aug 6, 2024

Sorry this is premature since the nix build in fact does not work due to missing libraries. investigating.

@faezs faezs marked this pull request as draft August 6, 2024 12:54
@AltGr
Copy link
Contributor

AltGr commented Aug 6, 2024

Thanks a lot ; indeed the nix build has been unmaintained for a while and there is likely to be a few missing dependencies. I'm not myself a Nix user, but any fix would be greatly appreciated :)

@faezs
Copy link
Contributor Author

faezs commented Aug 6, 2024

Luckily I've discovered the excellent opam-nix which obviates the need for maintaining separate derivations for each unlisted dependency and just uses opam-repository to find all the pinned versions. Everything builds on my system, if you re-enable nix ci hopefully it passes too.

@faezs faezs marked this pull request as ready for review August 6, 2024 16:31
@AltGr AltGr requested a review from adelaett August 8, 2024 12:46
@AltGr
Copy link
Contributor

AltGr commented Aug 8, 2024

LGTM, but I'll wait for @adelaett to review when he's back from holidays, as he knows Nix much better than I do. Thanks again.

@denismerigoux
Copy link
Contributor

@adelaett will not have the time to review (article deadline). I'm merging it :)

@denismerigoux denismerigoux merged commit 7747c99 into CatalaLang:master Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants