Skip to content

Commit

Permalink
chore(deps): update dev dependency flutter_lints to 5.0.0, solve warn…
Browse files Browse the repository at this point in the history
…ings (singerdmx#2292)

* chore(deps): update dev dependency flutter_lints to 5.0.0, solve warnings

* chore: remove redundant analysis error ignore

* chore: add avoid_web_libraries_in_flutter rule, remove empty analyzer declaration
  • Loading branch information
EchoEllet authored and CatHood0 committed Oct 28, 2024
1 parent e34ae5f commit ffe66fb
Show file tree
Hide file tree
Showing 16 changed files with 16 additions and 24 deletions.
5 changes: 1 addition & 4 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
include: package:flutter_lints/flutter.yaml

analyzer:
errors:
undefined_prefixed_name: ignore
unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
Expand Down Expand Up @@ -33,3 +29,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
avoid_web_libraries_in_flutter: true
1 change: 1 addition & 0 deletions dart_quill_delta/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ dependencies:
quiver: ^3.2.1

dev_dependencies:
# TODO: Using 4.0.0 to not require higher version of Dart SDK
lints: ^4.0.0
test: ^1.24.0
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dependency_overrides:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0
build_runner: ^2.4.8
flutter_gen_runner: ^5.4.0

Expand Down
5 changes: 1 addition & 4 deletions flutter_quill_extensions/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
include: package:flutter_lints/flutter.yaml

analyzer:
errors:
undefined_prefixed_name: ignore
unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
Expand Down Expand Up @@ -34,3 +30,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
avoid_web_libraries_in_flutter: true
2 changes: 1 addition & 1 deletion flutter_quill_extensions/lib/flutter_quill_extensions.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
library flutter_quill_extensions;
library;

// ignore: implementation_imports
import 'package:flutter_quill/src/editor_toolbar_controller_shared/clipboard/clipboard_service_provider.dart';
Expand Down
2 changes: 1 addition & 1 deletion flutter_quill_extensions/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0

flutter:
uses-material-design: true
5 changes: 1 addition & 4 deletions flutter_quill_test/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
include: package:flutter_lints/flutter.yaml

analyzer:
errors:
undefined_prefixed_name: ignore
unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
Expand Down Expand Up @@ -34,3 +30,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
avoid_web_libraries_in_flutter: true
2 changes: 1 addition & 1 deletion flutter_quill_test/lib/flutter_quill_test.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
library flutter_quill_test;
library;

export 'src/test/widget_tester_extension.dart';
2 changes: 1 addition & 1 deletion flutter_quill_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
sdk: flutter

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0

flutter:
uses-material-design: true
2 changes: 1 addition & 1 deletion lib/extensions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
'to expose certain internal APIs and should not be used directly, as it is subject to breaking changes.\n'
'The replacement is flutter_quill_internal.dart which is also for internal use only.',
)
library flutter_quill.extensions;
library;

// This file contains exports that are meant to be used
// internally and are not part of the public API as
Expand Down
2 changes: 1 addition & 1 deletion lib/flutter_quill.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
library flutter_quill;
library;

export 'src/common/structs/horizontal_spacing.dart';
export 'src/common/structs/image_url.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/quill_delta.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
library flutter_quill.delta;
library;

export 'package:dart_quill_delta/dart_quill_delta.dart';
2 changes: 1 addition & 1 deletion lib/translations.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
library flutter_quill.translations;
library;

export 'src/l10n/extensions/localizations_ext.dart';
export 'src/l10n/widgets/localizations.dart';
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ dependencies:
quill_native_bridge: '>=10.5.14 <=10.6.2'

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0
flutter_test:
sdk: flutter
flutter_quill_test: ^10.0.0
Expand Down
2 changes: 1 addition & 1 deletion quill_native_bridge/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
include: package:flutter_lints/flutter.yaml

analyzer:
linter:
rules:
always_declare_return_types: true
Expand Down Expand Up @@ -30,3 +29,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
avoid_web_libraries_in_flutter: true
2 changes: 1 addition & 1 deletion quill_native_bridge/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0

flutter:
plugin:
Expand Down

0 comments on commit ffe66fb

Please sign in to comment.