Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storing and map #11

Closed
wants to merge 3 commits into from
Closed

Refactor storing and map #11

wants to merge 3 commits into from

Conversation

NicolasGrosjean
Copy link
Contributor

Refactoring the store and the map to be like Mapathon Dashboard.

Summary of edits

  • Set Typescript classes in the classes directory
  • Use a store and state classes to manage the state
  • Add date filtering to the state to prepare Timeline #8
  • Split BaseMap script into 2 Typescript classes
  • Fix issue with date format

BUG : The markers are no more displayed because they are not draw when state change.
We need to export the Map in State like done in https://github.com/CartONG/mapathon_dashboard/blob/490448ff4a4c9682d79fb94b44b041ee15115ec3/src/classes/state.ts#L43
The date is in DD/MM/YYYY whereas I converted by assuming it was MM/DD/YYYY
@NicolasGrosjean NicolasGrosjean changed the base branch from main to develop May 13, 2021 10:06
@NicolasGrosjean
Copy link
Contributor Author

Already included in #12

@NicolasGrosjean NicolasGrosjean deleted the refacto/store branch May 30, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant