Add packet initializers for linear acceleration and angular velocity #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really good to me and considering you've tested and it works I'm sure it's fine; gonna just re-review this when I get back to my full monitor because I don't trust reviewing diffs on my phone lol |
linguini1
requested changes
May 15, 2024
src/main.c
Outdated
| just_added_block_size = sizeof(AngularVelocityDB); | ||
| add_block_header(DATA_ANGULAR_VEL, just_added_block_size); | ||
| angular_velocity_db_init((AngularVelocityDB *)packet_pos, last_time, | ||
| strtod(strtok(NULL, ","), NULL) / 10, strtod(strtok(NULL, ","), NULL) / 10, |
There was a problem hiding this comment.
Same idea here, multiplication not division. Packet spec is possibly not well worded, if you have any suggestions on a better way to word the descriptions lmk (I'm assuming it was just a misunderstanding because of the conversation we had on Discord).
linguini1
approved these changes
May 16, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Closes #60
This PR adds the packet initializers for linear acceleration and angular velocity