Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4278: Support for finality version in FE engine #52

Merged
merged 10 commits into from
May 21, 2024
Merged
5 changes: 5 additions & 0 deletions .github/workflows/_featurenet-create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ on:
type: string
required: false
default: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY'
finality-version:
description: 'Finality version to start FE with. Must be a cardinal number'
type: number
required: false
outputs:
ws-hostname:
description: Hostname of the WS endpoint
Expand Down Expand Up @@ -133,6 +137,7 @@ jobs:
git-commit-email: ${{ secrets.AUTOCOMMIT_EMAIL }}
wait-for-finalized-heads: "true"
sudo-account-id: ${{ inputs.sudo-account-id }}
finality-version: ${{ inputs.finality-version }}

- name: Finish featurenet Deployment
uses: bobheadxi/deployments@v1
Expand Down
9 changes: 9 additions & 0 deletions create-featurenet/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ inputs:
description: 'Sudo account ID'
required: false
default: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY'
finality-version:
description: 'Finality version to start FE with. Must be a cardinal number'
required: false
outputs:
ws-hostname:
description: Hostname of the WS endpoint
Expand Down Expand Up @@ -113,6 +116,10 @@ runs:
echo "!!! Invalid sudo-account-id"
exit 1
fi
if [[ ! '${{ inputs.finality-version }}' =~ ^[0-9]+$ ]]; then
echo "!!! finality-version must be a cardinal number"
exit 1
fi

- name: Checkout featurenet template repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -141,6 +148,8 @@ runs:
'${{ inputs.rolling-update-partition }}' \
'${{ inputs.expiration }}' \
'${{ inputs.sudo-account-id }}' \
custom-fnets-repo-not-used \
'${{ inputs.finality-version }}' \
${{ inputs.internal == 'true' && '-i' || '' }} \
-c -g | tee -a tmp-opssh-createfeaturenet-output.txt

Expand Down
Loading