Address internal review comments #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used only in owner_withdraw_token(reward_token) and we can fail the whole txn there if reward_token.balance_of turns out to be reverting. This is not blocking any loop from execution, since there's just one specific token argument.
deuszx
commented
Jan 10, 2024
| if reward_rate == 0 { | ||
| return Err(FarmError::InvalidFarmStartParams); | ||
| } | ||
| .ok_or(FarmError::ArithmeticError(MathError::DivByZero(3)))?; | ||
|
|
There was a problem hiding this comment.
Now we allow for zero reward rates for some tokens - i.e. there needs to exist at least one reward token with positive reward rate.
|
@krzysztofziobro PTAL one more time. |
krzysztofziobro
previously approved these changes
Jan 12, 2024
Co-authored-by: Krzysztof Ziobro <[email protected]>
krzysztofziobro
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.