Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace in-house psp22 and wnative contracts with external ones #54

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Conversation

h4nsu
Copy link
Contributor

@h4nsu h4nsu commented Nov 9, 2023

Disclaimer: code imported via submodules was formatted using default rustfmt settings and was causing make check-all to fail. I decided to remove non-standard rustfmt settings from this workspace, hence large diff caused by "reformatting".

Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be changing formatting in this PR, since they seem unrelated. Let's discuss separately.

@h4nsu h4nsu requested a review from deuszx November 10, 2023 12:45
Makefile Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for moving the build of test contracts out of the build-all Makefile job.

@h4nsu h4nsu merged commit e30321b into main Nov 10, 2023
1 check passed
@h4nsu h4nsu deleted the ext_dep branch November 10, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants