Skip to content

Commit

Permalink
L1-55 Fixed on push tag workflow (#1874)
Browse files Browse the repository at this point in the history
# Description

Since [we
changed](a0faac5)
versioning scheme, we need to adapt check in workflow on tag push.
Previously [it
worked](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/11235658890/job/31234074222)
since `version` in node's `Cargo.toml` was `0.X.Y`, now it is `X.Y.Z`.
Now it [does
not](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/12140381720/job/33850050691),
which this PR fixes.

## Type of change

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
Marcin-Radecki authored Dec 4, 2024
1 parent 98091cd commit cc81359
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/on-push-release-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ jobs:
run: |
# cut release candidate part of the tag
tag=$(echo '${{ steps.get-ref-properties.outputs.tag }}' | sed 's/-rc[0-9]*$//g')
# cut major version from Cargo.toml
expected_tag=r-$(echo '${{ steps.read-node-version.outputs.value }}' | sed -e 's/^[0-9]\+\.//g')
# expected tag is r-<version> from Cargo.toml
expected_tag=r-$(echo '${{ steps.read-node-version.outputs.value }}')
if [[ ${tag} != ${expected_tag} ]]; then
echo "Error: tag version does not match version in bin/node/Cargo.toml"
echo "Non-release candidate part of the tag is ${tag}"
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bin/node/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "aleph-node"
version = "14.0.0+dev"
version = "14.0.0"
description = "Aleph node binary"
build = "build.rs"
license = "GPL-3.0-or-later"
Expand Down

0 comments on commit cc81359

Please sign in to comment.