Skip to content

Commit

Permalink
A0-0000: Fix for gathering validator network data (#1903)
Browse files Browse the repository at this point in the history
# Description

Fix for regression introduced in
1d65f62#diff-787215c6ec15e1ecc63e5d3628fc9cce8a083c8c658f7ce2312ff0c5b0265d5eR219.

There would be a companion PR in `main` as well.

## Type of change

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)

# Testing

Run locally command:
```
 curl  -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method": "alephNode_unstable_validatorNetworkInfo", "params": []}' http://localhost:9944/
{"jsonrpc":"2.0","result":{"5GBNeWRhZc2jXu7D55rBimKYDk8PGk8itRYFTPfC8RJLKG5o":{"session":0,"network_level_address":"127.0.0.1:30344","validator_network_peer_id":"5FyuCn5rKTJdYDPTbT1Xhr8VjqYWYskNrudefpk4VQSpkQse"},"5DiDShBWa1fQx6gLzpf3SFBhMinCoyvHM1BWjPNsmXS8hkrW":{"session":0,"network_level_address":"127.0.0.1:30347","validator_network_peer_id":"5Ebkjsh9i9PyFYXDVxxXwPjwRSq9XQR2mJkgZoU5k9dX4ACp"},"5F4H97f7nQovyrbiq4ZetaaviNwThSVcFobcA5aGab6167dK":{"session":0,"network_level_address":"127.0.0.1:30346","validator_network_peer_id":"5CC71TV5oztBx3585vqrSEqQpeX8xvavjjBDy8ufAf7WA9CS"},"5Dfis6XL8J2P6JHUnUtArnFWndn62SydeP8ee8sG2ky9nfm9":{"session":0,"network_level_address":"127.0.0.1:30345","validator_network_peer_id":"5CroYKMd4ZCLkyf4oYGUZuB5XPswUDL4n69ptPpAMbHRfe6F"}},"id":1}⏎                                                         
```
  • Loading branch information
Marcin-Radecki authored Dec 31, 2024
1 parent 0788bc5 commit a993574
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions bin/node/src/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,7 @@ fn get_aleph_runtime_vars(client: &Arc<FullClient>) -> AlephRuntimeVars {
}

fn get_validator_address_cache(aleph_config: &AlephCli) -> Option<ValidatorAddressCache> {
aleph_config
.no_collection_of_extra_debugging_data()
.then(ValidatorAddressCache::new)
(!aleph_config.no_collection_of_extra_debugging_data()).then(ValidatorAddressCache::new)
}

fn get_proposer_factory(
Expand Down

0 comments on commit a993574

Please sign in to comment.