Consider more cards playable in main1 (#8589) #8590

CTimmerman · 2025-09-01T00:16:09Z

Fixes #8589. My Naya deck win rate improved by at least 50% when AI played it against its unpatched self.

I moved 0-mana, Exalted, and Extort checks before the RaidTest check as i don't think they reduce the number of blockers. The checks after RaidTest probably apply to cards that share that property with e.g. Blitz. I'm too tired to check atm.

forge-ai/src/main/java/forge/ai/ComputerUtil.java

Hanmac · 2025-09-01T07:29:21Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+            final String triggerZones = trigger.getParam("TriggerZones");
+            if (!"Battlefield".equals(triggerZones)) continue;


not all Trigger has TriggerZones set (unless you want to exclude ETB and LTB on purpose)

like for ChangedZone Trigger, it is set there, to the getActiveZone set:

forge/forge-game/src/main/java/forge/game/trigger/TriggerChangesZone.java

Line 216 in 0abc224

protected void correctZones() {

Afaik a permanent with TriggerZones "Battlefield" catches any other card entering or leaving the battlefield, and cards with ETBs are handled elsewhere.

Hanmac · 2025-09-01T07:31:47Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+                // 1312+ cards match `Mode\$ ChangesZone.*?TriggerZones\$ Battlefield`
+                // enter/leave triggers
+                // Admonition Angel etc
+                if (mode == TriggerType.ChangesZone || mode == TriggerType.ChangesZoneAll) {


Not all ETB trigger would be positive

Like Hunted Bonebrute would create tokens under opponents control, and would be better to be played after Combat?

I think a human deck creator would have anticipated that, but the AI is probably less discerning. I'll see if there are more negative than positive effects or the negative ones can be filtered out.

Check if the AI would play the Triggered Ability if it wasn't mandatory
this should filter out the bad ones

(see getDamageFromETB and checkETBEffects)

Also see AiController.doTrigger

Hunted Bonebrute matches Mode\$ ChangesZone.*?(?!TriggerZones\$ Battlefield) and such ETBs are handled elsewhere according to #8590 (comment)

forge-ai/src/main/java/forge/ai/ComputerUtil.java

tool4ever · 2025-09-01T09:05:32Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+                // 1312+ cards match `Mode\$ ChangesZone.*?TriggerZones\$ Battlefield`
+                // enter/leave triggers
+                // Admonition Angel etc
+                if (mode == TriggerType.ChangesZone || mode == TriggerType.ChangesZoneAll) {


too generic, besides PermanentCreatureAi already checks hasETBTrigger()
if you're worried about Landfall try improving the logic around PlayBeforeLandDrop

#8590 (comment)

PlayBeforeLandDrop still makes sure to drop land later in main1.

Is Ajani's Chosen worth playing in M1? Ajani's Welcome is marked as such, maybe because it's only 1 mana.

tool4ever · 2025-09-01T09:10:26Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+
+                // 1009+ cards match `Mode\$ SpellCast.*?ValidActivatingPlayer\$ You`
+                // Aetherflux Reservoir etc
+                if (mode == TriggerType.SpellCast && "You".equals(trigger.getParam("ValidActivatingPlayer"))) {


sequence wise this function should decide if there is something important enough to cast before combat (vs. leaving mana open for combat tricks)
Aetherflux Reservoir does not qualify, it should just be cast before other spells ideally so that's more of a use case for AIPriorityModifier

Spellslinger decks run such and prowess, right? So why not play Aetherflux Reservoir in main1?

forge-ai/src/main/java/forge/ai/ComputerUtil.java

tool4ever · 2025-09-01T09:22:08Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+
+            // 9+ cards match `S:Mode\$ IgnoreLegendRule`
+            // allow cloning your commander with Mirror Gallery; Myriad etc
+            if (mode.contains(StaticAbilityMode.IgnoreLegendRule)) {


too situational as default:
would at least need to check you have no non-legendary

Etherium Sculptor is not legendary. Your suggested addition breaks this combo: https://www.youtube.com/shorts/KlYmlTzA9kw?feature=share

that's nice but we're not adding very broad checks in general AI logic in the hopes of maybe playing a deck with some relevant combo...
FWIW allow me to demonstrate how you're managing to break very basic AI behaviour:

in case it's not clear enough - thanks to your change AI would prefer to lose from attack next turn instead of grabbing the win so Mirror Gallery can look threatening 💩

it's up to you to ensure you're not making too many such assumptions, otherwise your changes aren't mergeable

Thanks for the example. Can't that be solved by getSpellAbilityPriority?

forge-ai/src/main/java/forge/ai/ComputerUtil.java

tool4ever · 2025-09-01T09:24:42Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+            // 3+ cards match `S:Mode\$ ActivateAbilityAsIfHaste.*ValidCard\$[^|]*You`
+            // Thousand-Year Elixir etc
+            if (mode.contains(StaticAbilityMode.ActivateAbilityAsIfHaste)) {
+                if (validCard.contains("You")) return true;


too inaccurate

Only 3 cards match. Why put any in the deck if they're not useful? card.isAbilitySick() checks for this very ability.

tool4ever · 2025-09-01T10:31:09Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+
+            // 43+ cards match `K:Bestow`
+            final String bestow = nma.getParam("Bestow");
+            if (bestow != null && bestow.equals("True")) {


what's the point of casting in main1 just because it has Bestow?

Because Bestow is like an aura, and auras are already played in main1 because they boost creatures.

then you should test it
your logic does nothing because it's gonna be treated as Attach spell

Attach spells are also permanents, but I see Bestow is already checked in attachAIPumpPreference.

tool4ever · 2025-09-01T12:14:04Z

forge-ai/src/main/java/forge/ai/ComputerUtil.java

+
+            // 201+ cards match `S:Mode\$ ReduceCost.*?Activator\$ You`
+            // reduce cost to enable more plays
+            if (mode.contains(StaticAbilityMode.ReduceCost) && "You".equals(sta.getParam("Activator"))) {


again not worth the risk:
ai might just waste mana before combat

maybe they should get a slight boost in getSpellAbilityPriority() though (at least during early game)

Mana rocks are typically played first, and cost reduction should be even better.

you aren't understanding what I'm saying:
this function is for "main1 before main2"
hijacking it to add your "permanent A before B" logic just isn't supposed to happen here

What do you mean? Don't you think Alisaie Leveilleur, and Jet Medallion are worth playing in M1?

no, Jet Medallion does not help your combat directly
you'd need to at least be able to afford two additional playMain1 spells just to reach break even on mana spent vs. the risk of tapping out too early
this means on average it's a bad play

Ok, but Auriok Steelshaper would help equip and is a creature, and Ballyrush Banneret is a creature as well.

Is spending 1W in M1 worth a body and a 1 discount on Kithkin and Soldier spells? Deck-dependent.

Blood Funnel can pay for itself in monoblack, but requires creatures, which is probably checked when deciding to play it. (as well as it drawbacks). Fluctuator and Catalyst Stone also pay for themselves in the right decks. But all these have AI:RemoveDeck:Random

I'll leave ReduceCost to the card's SVar:PlayMain1.

CTimmerman force-pushed the Consider-more-cards-main1-playable branch 2 times, most recently from eeb03f4 to 9fbd606 Compare September 1, 2025 00:51

Hanmac requested review from Agetian, Northmoc, tehdiplomat and tool4ever September 1, 2025 07:20

Hanmac reviewed Sep 1, 2025

View reviewed changes

forge-ai/src/main/java/forge/ai/ComputerUtil.java Outdated Show resolved Hide resolved

Hanmac reviewed Sep 1, 2025

View reviewed changes

tool4ever reviewed Sep 1, 2025

View reviewed changes

forge-ai/src/main/java/forge/ai/ComputerUtil.java Outdated Show resolved Hide resolved

tool4ever reviewed Sep 1, 2025

View reviewed changes

forge-ai/src/main/java/forge/ai/ComputerUtil.java Show resolved Hide resolved

tool4ever reviewed Sep 1, 2025

View reviewed changes

forge-ai/src/main/java/forge/ai/ComputerUtil.java Show resolved Hide resolved

tool4ever reviewed Sep 1, 2025

View reviewed changes

forge-ai/src/main/java/forge/ai/ComputerUtil.java Outdated Show resolved Hide resolved

tool4ever reviewed Sep 1, 2025

View reviewed changes

Consider more cards playable in main1 (Card-Forge#8589)

e055ca7

CTimmerman force-pushed the Consider-more-cards-main1-playable branch from 9fbd606 to e055ca7 Compare September 1, 2025 21:54

		final String triggerZones = trigger.getParam("TriggerZones");
		if (!"Battlefield".equals(triggerZones)) continue;

Consider more cards playable in main1 (#8589) #8590

Are you sure you want to change the base?

Consider more cards playable in main1 (#8589) #8590

Uh oh!

Conversation

CTimmerman commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTimmerman Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTimmerman Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTimmerman Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tool4ever Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTimmerman Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTimmerman Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

CTimmerman commented Sep 1, 2025 •

edited

Loading

CTimmerman Sep 1, 2025 •

edited

Loading

CTimmerman Sep 1, 2025 •

edited

Loading

CTimmerman Sep 2, 2025 •

edited

Loading

tool4ever Sep 2, 2025 •

edited

Loading

CTimmerman Sep 1, 2025 •

edited

Loading

CTimmerman Sep 2, 2025 •

edited

Loading