-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chosen letter support (Unsets) #6636
base: master
Are you sure you want to change the base?
Conversation
xD |
forge-game/src/main/java/forge/game/ability/effects/ChooseLetterEffect.java
Show resolved
Hide resolved
forge-game/src/main/java/forge/game/player/PlayerController.java
Outdated
Show resolved
Hide resolved
Apropos Letter in Card Name, we should normalize them for names like see: forge/forge-core/src/main/java/forge/util/TextUtil.java Lines 49 to 54 in 1bee1a4
|
forge-game/src/main/java/forge/game/ability/effects/ChooseLetterEffect.java
Outdated
Show resolved
Hide resolved
@Northmoc you still need an extra List if you want to support vowels (because Y can be both) Also
But i think for us, it is more simple if we normalize them? |
Correct - nothing uses vowels yet
I think so too |
A decent draft, I think