-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add avatar component #689
base: release/1.1.0
Are you sure you want to change the base?
Add avatar component #689
Conversation
@cg-julian-taylor please can you alter the without style avatar documentation to use the text instead of the link. I also think when using the external link you shouldn't see text Please can you also make sure the avatar component is at the top of the documentation to keep it in alphabetical order |
No problem with changing the without style documentation. It does look a bit odd. As for what you pass in to the avatar itself I believe you should be able to pass in an aria-label as a prop. I assume the typical use case of passing an image url or initials, however I wanted to demonstrate that the contents are flexible so used an external link as that was the most likely use case I could think of adding. I also made the assumption that if a user is injecting something such as an SVG they would manipulate styling. However if I am wrong or you disagree please let me know what use cases I should aim for. |
@cg-julian-taylor can you please remove the design system folder from storybook as it is currently broken. It will be picked up in a separate ticket as it requires a bit more work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/1.1.0 #689 +/- ##
===============================================
Coverage 100.00% 100.00%
===============================================
Files 89 90 +1
Lines 1663 1678 +15
Branches 584 591 +7
===============================================
+ Hits 1663 1678 +15 ☔ View full report in Codecov by Sentry. |
No description provided.