Add standard tags to ECS logs #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallyx3
reviewed
May 21, 2024
enricher/ecs/ecs.go
Outdated
| ecsTaskFamily: ecsTaskFamily, | ||
| ecsTaskRevision: ecsTaskRevision, | ||
| canvaAWSAccount: os.Getenv("CANVA_AWS_ACCOUNT"), | ||
| canvaApplicationId: os.Getenv("CANVA_APP_ID"), |
There was a problem hiding this comment.
Needs to be updated to reflect change in https://github.com/Canva/canva/pull/507179
mallyx3
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Want ECS lgos to come with standard stags.
Description of changes:
Attach additional resource tags to the logs. This PR adds the necessary env variables are set in the deploy script
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.