feat: add links and language switcher to header #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Nixon <[email protected]>
|
Not all of the new strings have been translated. For instance you can see in the screen shot that "Our Values" was not in the translations that we already have. I would like to get new, human translations for everything but for now I'll add machine translations. In another PR. |
GeraldMit
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
LGTM!
review was code visual look only... ignored colors (colorblind) but codes seemed correct. Language translations generally look good but I can't confirm the added bracketing in bi-directional languages are correct in logical vs. visual ordering, in rtl and so on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
Added links to the header. There were in the header in 2023 but were unintentionally omitted in 2024.
Type of change
Checklist: