Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Factor refactoring. Introduce TwoFactorProcessors. #1072

Draft
wants to merge 1 commit into
base: 11.next-cake4
Choose a base branch
from

Conversation

skie
Copy link
Member

@skie skie commented Feb 8, 2024

extract two factor logic into separate classes processing each type of 2fa.
Requires auth 7.3.0 after release.

@skie skie marked this pull request as draft February 8, 2024 22:51
@steinkel
Copy link
Member

steinkel commented Feb 9, 2024

It looks good. It has breaking changes though, we may need to consider a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants