PKGBUILD: Drop .install script #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .install script we had all this time for the rt kernel was never ran on upgrades and installs due to being "sourced" incorrectly in the PKGBUILD. It should have been "sourced" in `install=` instead for it to be ran. However, sourcing it this way poses a few problems: 1. If we add `install=` along in the case statements for cpusched types, the post install script will be ran for each kernel package installed. 2. We could add it to the _package() function for the kernel, but this needs if statements so that its ran on the correct kernel flavour (clutter IMO). Adding it *only* for the rt kernel in case of `linux-cachyos-rt.install` would make its PKGBUILD inconsistent with others (a case can be made that the default kernel is now inconsistent with the other PKGBUILDs, but the default kernel in nature will always be subject to some changes that will not be seen by the other kernel variants) Due to the aforementioned problems, drop the post install scripts. This decision was also largely in part of the low usage count of the rt kernel. We will also be removing `linux-cachyos.install` anyway as it is only a temporary addition to smooth out migration. Signed-off-by: Eric Naim <[email protected]>
ptr1337
approved these changes
Oct 6, 2024
Why? I don't get why this has to be called for every kernel. The .install scripts are per-package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .install script we had all this time for the rt kernel was never ran on upgrades and installs due to being "sourced" incorrectly in the PKGBUILD. It should have been "sourced" in
install=instead for it to be ran. However, sourcing it this way poses a few problems:install=along in the case statements for cpusched types, the post install script will be ran for each kernel package installed.linux-cachyos-rt.installwould make its PKGBUILD inconsistent with others (a case can be made that the default kernel is now inconsistent with the other PKGBUILDs, but the default kernel in nature will always be subject to some changes that will not be seen by the other kernel variants)Due to the aforementioned problems, drop the post install scripts. This decision was also largely in part of the low usage count of the rt kernel. We will also be removing
linux-cachyos.installanyway as it is only a temporary addition to smooth out migration.