Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

根据原型图完成了商城界面 #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fuxiao156
Copy link

由于不知道如何融入图片比较合适,于是就完全照着原型图的样子绘制了页面

// price:价格 number
// detaillink:详情页链接地址 string
// buylink:购买页面链接地址 string
// tipType:提示类型,0:即将上线,1:进行中,2:已结束 number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看要不写个 interface ?

},
];
// tip的类型
const tipType = ['future', 'now', 'past'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搞个 enum 吧

@@ -0,0 +1,177 @@
.marketPage {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们的项目用了 tailwind css。可以用 tailwind 实现的样式可以迁移过去,其他实现不了的再另外写。另外命名规范可以参考 BEM ,不强制,不过建议至少是 snake-case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里优先使用组件库吧,tailwind其实是打算在后面开发中去掉的,不使用就不使用,我们用的是字节的arcodesign,如果有arco组件就优先使用arco组件,样式就用css就可以

@DevRickLin
Copy link
Contributor

DevRickLin commented Nov 2, 2023

by the way, 虽然也不是强制(毕竟之前其他人也不是很规范),不过后面稍微注意下 commit 规范是好事,可以参考我的其他 commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants