Content registration #9
Conversation
| tagTypes: ['schemaApi'], | ||
| extractRehydrationInfo(action, { reducerPath }) { | ||
| if (action.type === HYDRATE) { | ||
| return action.payload[reducerPath]; | ||
| } | ||
| }, | ||
| endpoints: (builder) => ({ | ||
| putSchema: builder.mutation<SchemaFormType, SchemaFormType>({ | ||
| putSchema: builder.mutation<any, any>({ |
There was a problem hiding this comment.
Should there maybe be a proper type/interface here instead of any? Seems like a place where you would like to leverage typing checks, to make sure you're sending a valid payload, and getting back data the way you want?
There was a problem hiding this comment.
it was quick do over to make the put work. I have to think about the correct interface type that the backend accepts.
| @@ -73,6 +74,7 @@ export default function UpdateWithFileModal({ | |||
| if (fileData) { | |||
| const formData = new FormData(); | |||
| formData.append('file', fileData); | |||
| console.log('in file modal' + formData); | |||
There was a problem hiding this comment.
Should we maybe clean up console logs as well? We don't want them to end up in production, at least.
| key={item.pid} | ||
| onClick={() => handleClick(item.pid)} | ||
| onMouseEnter={() => item.onMouseEnter && item.onMouseEnter()} | ||
| onMouseLeave={() => item.onMouseLeave && item.onMouseLeave()} |
There was a problem hiding this comment.
Are these supposed to do something? Did these not break, since you removed the onMouseLeave and onMouseEnter attributes from the Schema interface?
There was a problem hiding this comment.
no, I will add the click event on the list component :)
There was a problem hiding this comment.
At some point we need to change every 'status' into state, since I think that's the term we have decided to use in MSCR for draft/published etc. Also we need to refactor overlapping interfaces.
| }, [schemaFormInitialData]); | ||
|
|
||
| useEffect(() => { | ||
| if (userPosted && result.isSuccess) { | ||
| if ((userPosted && resultSchema.isSuccess) || resultSchema.isSuccess) { |
There was a problem hiding this comment.
Is it just my Friday afternoon brain, or does the userPosted not really matter in this condition? If resultSchema.isSuccess is true, this statement is true regardless of userPosted, right?
There was a problem hiding this comment.
it was my friday afternoon brain!! good catch. This does not make any sense. I will fix it
Schema Registrationa with File or only with metadata is working with the real datamodel api backend. Features working are