DRAFT: Unfinished merge request from CSCFC4EMSCR-633 branch to develop branch #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o in crosswalk editor. There is a problem content update on pop up view, when opening mapping on Mapping view tab. Pop up data is updated on crosswalk editor tab.
|
What's the status of this now that the designs have changed quite a bit? If I understood correctly, you had a problem with getting the mapping editing pop-up window to open with the correct mapping info? |
|
@jkesanie mentioned that this pop-up window is not needed in future. I am also doing ticket CSCFC4EMSCR-646 "Filtering of mappings based on schema tree node selection" based on this branch. So this branch has a base for future changes, because it has this new mapping tab. |
|
Ok! If you need to ask about something else in the old editor code or the redux files or anything, make an updated MR and let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving unfinished changes. Mapping view is located on own tab and also in crosswalk editor. There is a problem on content update on pop up view, when opening mapping on Mapping view tab. Pop up data is updated on crosswalk editor tab.