Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSCFC4EMSCR-585 Change node elementpath to array to fix tree selection #239

Merged

Conversation

maariaw
Copy link

@maariaw maariaw commented Dec 10, 2024

Elementpath changed to an array of all node ids on path to node

@masillan
Copy link
Member

masillan commented Dec 11, 2024

Seem to work quite similar with couple manual testcases on local development environment. Difference is at least removing ROOT element from tree. (I noticed that function getAllNodeIdsOnPathToLeaf has still: const nodeIdsOnPath = path.split('.');
Hopefully this is just remnant of old code and actual splitting is not needed.) <= This was on comparison between develop and 585.

@masillan
Copy link
Member

I think that this version is doing less operations to fix error compared my version. Maybe this version could be merged, it looks simpler, but not sure if code is easy to understand.

@maariaw maariaw requested a review from masillan December 11, 2024 10:22
@masillan
Copy link
Member

Looks good!

@masillan masillan closed this Dec 11, 2024
@masillan masillan reopened this Dec 11, 2024
@masillan masillan merged commit df14a39 into develop Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants