CSCFC4EMSCR-599 Fix mapping table rendering for all schema formats pull request to develop #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded root element as parent class to path in SHACL format where mapped element is the child of root element. Returning label / name of mapped element, if format is not SHACL, Xsd ,Csv Jsonschema, Enum or Mscr.
maariaw
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I didn't test separately, since @jkesanie said it looked good. I commented on just a couple formatting things, but it might be best if you just fixed all of the formatting at some point later, after we get your automatic lint checker to work.
| @@ -376,18 +376,11 @@ function returnPath(id: string, label: string, schemaFormat: Format | undefined, | |||
| } | |||
| } | |||
| return returnString; | |||
| } else { | |||
|
|
|||
| let className = ''; | |||
| className = id.substring(id?.lastIndexOf('/') + 1, label.lastIndexOf('#')) + ':'; | ||
| let itemName = id.substring(id.lastIndexOf('#') + 1); | ||
| returnString = className + itemName; | ||
| } | ||
| } else if (schemaFormat === Format.Shacl) { |
There was a problem hiding this comment.
Check the indentation, seems like this whole block might have one extra indentation, since it should be level with the original if-statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aded root element as parent class to path in SHACL format where mapped element is the child of root element. Returning label / name of mapped element, if format is not SHACL, Xsd ,Csv Jsonschema, Enum or Mscr.