Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSCFC4EMSCR-561 pull request to develop #227

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

masillan
Copy link
Member

CSCFC4EMSCR-561 Clicking mapping source/target node only highlights one side of the schema trees: Changed clicking mapping source/target to highligt both source and target on crosswalk schema trees.

…ne side of the schema trees: Changed clicking mapping source/target to highligt both source and target on crosswalk schema trees.
@masillan masillan self-assigned this Oct 31, 2024
Copy link

@maariaw maariaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully in most cases. With a SHACL schema it didn't open parent nodes, but we might want to investigate that separately. Works with my CSV, JSON, XSD and SKOSRDF test schemas at least. SHACL I tested with https://mscr-test.2.rahtiapp.fi/schema/mscr:schema:6e832593-3800-4db7-856e-fadb50e7b4d6 (download button at the bottom of page)

@rquazi
Copy link
Member

rquazi commented Nov 11, 2024

What is the status then, if we wanna investigate SHACL separately? should we then merge this PR to develop @maariaw

@maariaw
Copy link

maariaw commented Nov 11, 2024

If that's ok with @masillan ? You're not still working on this? Should I make a ticket for the SHACL fix if we merge this now?

@masillan
Copy link
Member Author

CSCFC4EMSCR-599 have at least one fix for SHACL in case where mapped field is child of root element. Root element will appear as parent class of mapped field. There is now another pull request for CSCFC4EMSCR-599 open.

@masillan masillan merged commit 20830aa into develop Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants