Cscfc4 emscr 422v2 #169
Cscfc4 emscr 422v2 #169
Conversation
| if (!formData) { | ||
| return; | ||
| } | ||
| function isFormValid() { |
| </div> | ||
| <div className="col-6"> | ||
| <div | ||
| style={{ display: 'flex', flexDirection: 'column', gap: '20px' }} |
There was a problem hiding this comment.
Why does this need a styling container when the same component in crosswalk modal doesn't? If it's necessary, should it be in form.styles?
There was a problem hiding this comment.
No idea what this is for, haven't written it. Most likely redundant.
| @@ -31,23 +48,35 @@ export default function TargetAndSourceSchemaSelector({ | |||
| createNew, | |||
| schemaSelectorDisabled, | |||
| }: CrosswalkFormProps) { | |||
| const user: any = useSelector(selectLogin()); | |||
| setSelectedSourceWorkspace(e); | ||
| }} | ||
| > | ||
| {workspaceValues.map((format) => ( |
| ); | ||
| } else { | ||
| setTargetSchemas( | ||
| defaultSchemas.filter((item) => item.organization !== '') |
There was a problem hiding this comment.
Shouldn't this be done like the owner is, so you get all organizations in the item.organization, and then check if it includes the organization whose workspace the modal was opened from? The group pid is already passed to the modals, so you just need to thread it through CrosswalkFormFields to get it here as well.
Although as discussed, eventually we'll want to implement this so that the selected filter determines what to fetch from the backend, so I don't know how much more effort we want to put to the interim solution.
No description provided.