Create a new workflows endpoint

[csc-felipe]

Description

Workflows define the process for creating and publishing a submission.

Related issues

• Fixes Add workflows endpoint to set objects order in front-end #362

Type of change

• New feature
  This PR doesn't have breaking changes

Changes Made

• Added workflow schema
• Added initial workflow descriptions
• Added check for the workflow schema
• Updated OpenAPI schema with new endpoints

Testing

• Unit Tests
• Integration Tests
• Schema validation

Mention

This change has features that can be used in the frontend, but breaking changes will come in a future PR. @hannyle

[csc-felipe]

How can we describe the DAC and Policy in a way that works for ENA schema, and also REMS in a more general manner?

[csc-felipe]

Now I'm thinking that the code change that enforces the workflows could come as a follow-up PR. It starts to be quite large.

[blankdots]

Now I'm thinking that the code change that enforces the workflows could come as a follow-up PR. It starts to be quite large.

so does this PR fixes #362 and should be reviewed as such ?
not sure i follow the enforces the workflows could we have more details ?

[csc-felipe]

so does this PR fixes #362 and should be reviewed as such ?

#362 was about adding endpoints for the front-end, and that has been done in the current PR.

not sure i follow the enforces the workflows could we have more details ?

Additionally, the backend should check that the

• submission actually follows the workflow
• which workflow the submission follows
• which services the submission has to be published to
• required schemas and other constraints, as defined in the workflow, have been followed

After all, the service will be used not only by the front-end, but also directly via API.

What do you think, does it make any sense?

[blankdots]

What do you think, does it make any sense?

yes, thank you. Sounds like a new task.

🤔 (brainstorming) we might need to add to the submission.json which workflow was used in this submission, but getting ahead ...

[csc-felipe]

Indeed, it was getting ahead of myself, and implementing that functionality already. Created a new issue for this feature #591

[blankdots]

small notes at a first glance

[blankdots]

I am not sure if these should be handled by this PR or another one ?

i think we don't need METAX_ENABLED and REMS_ENABLED given that most things are going to be handled by the workflow.
at the same time, ServiceHandler and its sub-classes DataciteServiceHandler, MetaxServiceHandler and RemsServiceHandler don't need enabled property.

there are also some self.metax_handler.enabled and self.rems_handler.enabled cases

[csc-felipe]

I am not sure if these should be handled by this PR or another one ?

I think that to remove the service enabled checks it requires implementing the workflow "enforcements" mentioned before. I wrote the task you mentioned to this issue: #591

Comments were addressed

[csc-felipe]

Rebased to fix conflicts