unset is_sending_ during tce restart #689
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #668
During
tcp_client_endpoint_impl::restart()
thequeue_
will be drained, messages printed likeand if
is_sending_
was set nothing will unset. Later inconnect_cbk()
:there's nothing queued, no reason to call
send_queued
, therefore no callback is going to clear the flag. Flagis_sending_
remains set "forever" and the train logic remains blocked from sending. From a user perspective the client endpoint would receive notifications but never transmit anything again.This needs to be cleared during
restart()
whenqueue_
gets drained