Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared conference data #13

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Add shared conference data #13

merged 6 commits into from
Sep 5, 2024

Conversation

rileychh
Copy link
Contributor

As discussed in a thread of the COSCUP Mattermost.

@rileychh rileychh force-pushed the shared-conference-data branch 2 times, most recently from 39c2d53 to 845999f Compare August 31, 2024 07:53
@rileychh rileychh marked this pull request as ready for review September 2, 2024 15:27
@@ -18,10 +22,10 @@ export default defineConfig({
Icons({ compiler: 'vue3' }),
],
},
title: 'COSCUP 2024',
title: `COSCUP ${conference.year}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以幫我整個 title 都弄成變數嗎?之前有聯名,title可能不是這個格式

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.md 的 frontmatter 怎麼辦,那裡不能代變數

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

發 issue 或 pr 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以幫我整個 title 都弄成變數嗎?之前有聯名,title可能不是這個格式

ebb7b1e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999556b 把 description 也變成變數了。

Copy link
Contributor

@mirumodapon mirumodapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileychh rileychh merged commit d982cdb into main Sep 5, 2024
1 check passed
@rileychh rileychh deleted the shared-conference-data branch September 5, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants